Return the plist value instead of the type #23721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaf
approved these changes
Sep 2, 2025
Contributor
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
|
/azp run xamarin-macios-pr |
|
No pipelines are associated with this pull request. |
rolfbjarne
reviewed
Sep 3, 2025
Member
rolfbjarne
left a comment
rolfbjarne
left a comment
There was a problem hiding this comment.
Would it be possible to get tests for this task as well? We don't seem to have any existing tests, but it should go in this directory: https://github.com/dotnet/macios/tree/main/tests/msbuild/Xamarin.MacDev.Tasks.Tests/TaskTests
Contributor
Author
Yes Sir - unit tests added |
Contributor
Author
|
@dotnet-policy-service agree |
rolfbjarne
approved these changes
Sep 10, 2025
Member
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the value from a propertylist, the value is of base type PValueObject. When returning value.ToString() we get the type and not the actual value.
FIX: We check and cast to IPValueObject and return the actual value.